Do not execute make_graph function again after define function in Dag class

AustralianSynchrotron / lightflow

A lightweight, distributed workflow system

https://australiansynchrotron.github.io/lightflow/

BSD 3-Clause "New" or "Revised" License

98 stars 18 forks source link

Do not execute make_graph function again after define function in Dag class #18

Open Light-Gao opened 5 years ago

Light-Gao commented 5 years ago

I believe it's worth that keeping graph defined already as an attribute of Dag class. Since in most of those cases, people would define graph firstly. Thus, it would take redundant moves if we execute make_graph() again.

Light-Gao commented 5 years ago

Travis job went failed when testing with python3.6.
Error message: PluginValidationError: Plugin 'pytest_cov' could not be loaded: (pytest 3.3.0 (/home/travis/virtualenv/python3.6.3/lib/python3.6/site-packages), Requirement.parse('pytest>=3.6'))!

Obviously, it's dependency issue. Could it be possible that we put specific version number about pytest in requirement-dev.txt ? Say pytest>=3.6 ?