AustralianSynchrotron / openday-scavenger

Open Day Scavenger Hunt App
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

Favicon not working on Edge #90

Open stmudie opened 5 days ago

stmudie commented 5 days ago
chanmSC commented 1 day ago

That's because there's no manifest.manifest file for Edge. Microsoft requires a separate way to include favicons.

We'd need to add a manifest.manifest file into the static folder (where favicon.ico is) with sth like this:

{
    "lang": "en",
    "short_name": "Open Day Scavenger Hunt",
    "name": "Australian Synchrotron Open Day – Unlock the Secrets of the Australian Synchrotron",
    "icons": [
        {
            "src": "favicon.ico",
            "sizes": "64x64 32x32 24x24 16x16",
            "type": "image/x-icon"
        }
    ],
    "start_url": "./",
    "display": "standalone",
    "theme_color": "#1a3869",
    "background_color": "#ffffff"
}

And then every layout & everyone's individual index.html in the <head> would have to include:

 <link rel="manifest" href="/static/manifest.webmanifest" />

I didn't think we'd be able to get everyone manually update their <head>, and we can't update it for ppl, unless we're willing to test & possibly fix everyone's puzzle locally (!doctype can break certain js code, or not break, but it can require certain syntax), so I just left as is for this Open Day 😅