AutarchLLC / foundryvtt-acks-core

Adventurer Conqueror King System Imperial Imprint (ACKS II) core game module for the Foundry Virtual Tabletop.
https://autarch.co
Other
6 stars 2 forks source link

Equipment Compendium Additions and Updates #16

Closed wyatt-kinkade closed 1 week ago

wyatt-kinkade commented 4 months ago

Updated Armor Types to reflect the new edition's verbiage and the tables in the Revised Rulebook.

Updated Localization Files to reflect new Armor Types

Updated Armor Compendium to...

Created Barding Compendium with Bardings of all combinations of possible configurations (Full, Half, Spiked)

Added Compendium to those to be loaded by the System

ArcanistWill commented 4 months ago

I took a quick look and have some review comments before committing.

  1. The new compendium needs to be created in the same manner as following the build guide from the article. This walks you through creating a formatted data file then building it into a pack - See this article especially Pack Structure subsection which provides example: https://pumbers.github.io/game-manglement/articles/vtt_compendia_building/
  2. Please refer to item 4 of the roadmap: https://github.com/orgs/AutarchLLC/projects/1/views/9
  3. There will need to be some updates to the weights to change the encumbrance units away from Coins into Stone (sixths of stone to be precise). Please read item 2 of the roadmap: https://github.com/orgs/AutarchLLC/projects/1/views/9
wyatt-kinkade commented 1 week ago

Going to sit down and rework my side, I still have some files, but I cannot seem to get the gulp script to work nicely at the moment.

ArcanistWill commented 1 week ago

I was just thinking about this pull request earlier today. The equipment and encumbrance work is next on our list. I was going to ask if you wanted to do a rebase to get the latest updates from the main branch and then we can work to get your contributions in sync. I think we're going to have our developer work on the character sheet and the calculations, and you and I can work the compendium updates and clean up the text and all that.

There will be a new release early Monday. We are merging the initiative work on to the master branch. It's done and ready to go! So that would be a good time to grab an update.