Findings from testing Gold and Money feature

ArcanistWill commented 1 month ago

Observations - not an error

Money on character sheet still allows use of the "+" button to manually add Money items, but I think that is OK because it allows adding non-standard money during a campaign. I do not think it's necessary to delete the "+" action.

Fix to Encumbrance for money

The character's coins that they are carrying should be included in their Encumbrance. The total number of coins from all coin types marked as being carried should be totaled together.
- Units of every 166 coins counts as 1 item (1/6 of a stone)
- Units of every 1000 coins is 1 stone (6 items)
- Modulo-1000 to get number of stone, Divide remainder by 166 and round up to get number of items.
Add 2 separate counts of each money being tracked: The first is for coins being carried on character, the second is for money stored in the bank. The first counts for Encumbrance. The second does not.
```
coin       carried     banked
pp         100         450
gp         250        2000
ep           0           0
sp        1250         175
cp           0           0
```
Bugs
The display order used for the Money on the character sheet inventory is not in logical order. It should be displayed either in most-valuable to least-valuable, or else in the opposite. Currently Incorrect display is out of order as:
- Platinum
- Electrum
- Copper
- Gold
- Silver
The desired order is:
- Platinum
- Gold
- Electrum
- Silver
- Copper
Change the label for the money units from GC to gp - short for "gold pieces". The text GC is used in a few places and that is incorrect.

Issues

For all money values, can we make the field read-only (except for the GM or assitant GM role) for the field "Value (in Copper Coin)" - we want only the GM to be able to change the Value for money definitions.
For the Money columns displayed on character inventory, with no decimals, there are rounding confusion and we think it would be better to have decimal points shown.
- Change the column's total Value (gp) to include 1 decimal point.
- Change the displayed gp total for the Copper money (cp) to show 2 decimal points, and the others (I think) 1 decimal point. See how that looks

Potential Change

Is it possible to reverse the "payment order" so that the money is deducted from the smallest-denomination (least valuable) coins first, and allows keeping the most valuable coins when possible?

LeRatierBretonnien commented 1 month ago

All fix implemented. I do not exactly what means this : Is it possible to reverse the "payment order" so that the money is deducted from the smallest-denomination (least valuable) coins first, and allows keeping the most valuable coins when possible? as there is no automated payment system in the game. Need precision on this.

ArcanistWill commented 1 month ago

All fix implemented. I do not exactly what means this : Is it possible to reverse the "payment order" so that the money is deducted from the smallest-denomination (least valuable) coins first, and allows keeping the most valuable coins when possible? as there is no automated payment system in the game. Need precision on this.

Agreed, I didn't explain it well. Here is a better description.

If I have henchmen assigned, and I use the Pay Wages button, this looks as if it correctly takes the funding from the inventory. We are asking if it is possible to change the selection order of deducting the payment start with the least-valuable coins first (Copper), instead of starting with Platinum?

Here is an example before & after: