search

AutarchLLC / foundryvtt-acks-core

Adventurer Conqueror King System Imperial Imprint (ACKS II) core game module for the Foundry Virtual Tabletop.
https://autarch.co
Other
9 stars 3 forks source link

Oddities with "Packed Item" Handling #73

Open wyatt-kinkade opened 3 weeks ago

wyatt-kinkade commented 3 weeks ago

Describe the bug When handling items that come in groups odd behavior occurs

To Reproduce/Expected Behavior Steps to reproduce the behavior: Add a package of 12 iron spikes If it is set to 1 unit of weight (i.e. 1/6th of a stone), the encumbrance calculations will assume it is 12 units (i.e. 2 stone) 1 package of iron spikes is 1/6 of a stone. Similar situations occur for cases of crossbow bolts or quivers of arrows. However This behavior correctly models some things, for example this is exactly the desired behavior for rations or torches which each weigh 1/6th of a stone each item even if one assumes getting multiple.

Additional context Again, this has a few ways it could be resolved, I don't know what the preferred resolution for this is.

LeRatierBretonnien commented 3 weeks ago

I am not sure to understand exactly. Do you mean the 12 iron spikes should be 2 stones instead of 1 in the item sheet?

EDIT : OK, understood. I suggest to change the weight of the item to be 0.08 (which provides 1 when multiplied by 12).

wyatt-kinkade commented 3 weeks ago

I'd also note quivers of arrows and cases of bolts to be similarly affected.

EDIT: Presumably they would weigh 0.05 given there's 20 of them

LeRatierBretonnien commented 3 weeks ago

@ArcanistWill -> If you agree, I can update the compendium values in the sheet-rework branch

ArcanistWill commented 3 weeks ago

@ArcanistWill -> If you agree, I can update the compendium values in the sheet-rework branch

Yes. I had to read this several times to understand it, but yes I do agree this makes sense to me now and it seems like a good fix.

I think this is something I'll need to add to the how-to for upgrading, if people need to update their characters, to explain how encumbrance works.