search

AutarchLLC / foundryvtt-acks-core

Adventurer Conqueror King System Imperial Imprint (ACKS II) core game module for the Foundry Virtual Tabletop.
https://autarch.co
Other
6 stars 2 forks source link

A Spell Description links to what? #8

Closed ArcanistWill closed 2 weeks ago

ArcanistWill commented 5 months ago

Describe the bug In the chat log, a spell description has selectable links that give the impression they do something. What's this about?

I think this is a bug, not a feature enhancement, but it seems to have been present in the old code too.

To Reproduce Steps to reproduce the behavior:

  1. Create character with at least one spell: Bless
  2. Click on the spell's icon so it rolls and appears in the chat log
  3. Click on chat log - these look like selectable item links
  4. See error

Expected behavior Unclear - is this supposed to open up the corresponding item description? That would be nice. What else?

Screenshots spell-item-links-what

LeRatierBretonnien commented 5 months ago

This is auto-link to items when "something" (ie actor, scene,item, rolltable ,...) is dropped onto a journal: image

It allows to do easy linking between "objects" of the game.

In this specific case, the description of "Bless" has been enhanced with a link to a "Holy Water" item from the world itself. As this "Holy Water" item does not exist in the world (neither in compendiums, it seems), the auto-link is displayed as a broken one.

ArcanistWill commented 5 months ago

This is auto-link to items when "something" (ie actor, scene,item, rolltable ,...) is dropped onto a journal: image

It allows to do easy linking between "objects" of the game.

In this specific case, the description of "Bless" has been enhanced with a link to a "Holy Water" item from the world itself. As this "Holy Water" item does not exist in the world (neither in compendiums, it seems), the auto-link is displayed as a broken one.

I understand your explanation. However I am confused because it does exist in compendium - see image. Does this mean that the link is corrupted?

image

LeRatierBretonnien commented 5 months ago

The link is not "corrupted", it is completly wrong. Here is the current link : image

And here is the link from the item in the compendium (ie the correct link) : image

Basic rule : Alaways do linking from compendiums, not items in the world.

ArcanistWill commented 2 weeks ago

I am closing this issue because all of the current spells in the compendium have to be revised to update them for ACKS II. During that process we should also fix any links to items.

There is no point keeping this open.