search

AutarchLLC / foundryvtt-acks-core

Adventurer Conqueror King System Imperial Imprint (ACKS II) core game module for the Foundry Virtual Tabletop.
https://autarch.co
Other
6 stars 2 forks source link

Clicking spell roll in chat causes error #9

Closed ArcanistWill closed 2 weeks ago

ArcanistWill commented 5 months ago

Describe the bug When clicking some spells' dice rolls, an error is produced.

Confirmed that this issue was present from the older ACKS code.

See solution comment below - https://github.com/AutarchLLC/foundryvtt-acks-core/issues/9#issuecomment-2016542386.

Plan to Fix This bug should be addressed as part of the compendium rework.

To Reproduce Steps to reproduce the behavior:

  1. Create actor with at least 1 Spell: Sleep
  2. Click on the spell's icon to roll it
  3. The spell appears in the chat log
  4. Click on the associated dice roller in the chat log
  5. The error appears in the console

Expected behavior The expected result is for a die roll to take place.

Screenshots From Foundry v11: image

From Foundry v9: image

LeRatierBretonnien commented 5 months ago

This issue is already present in the v9 version. In this case, the roll formula is not a valid Foundry roll formula: image

The 'HD' term is not understood by the Foundry roll engine, hence the error.

Solution : remove the 'HD' from the roll formula in this spell.

ArcanistWill commented 2 weeks ago

I am closing this issue because all of the current spells in the compendium have to be revised to update them for ACKS II. During that process we should also fix any rolls that are present.

There is no point keeping this open.