search

AutarkLabs / open-enterprise

A suite of apps that includes allocation, dot voting, issue curation, and other planning tools so organizations can collectively budget and design custom reward & bounty systems.
GNU General Public License v3.0
92 stars 54 forks source link

add storage to oe template (not working) (DO NOT MERGE) #1720

Open Schwartz10 opened 4 years ago

Schwartz10 commented 4 years ago

Hey @Quazia @ottodevs and @topocount this is my first attempt at adding a default storage app to the OE template. This first commit is just to get the contracts working, and not any of the frontend / parcel stuff yet.

Important files:

changes to BaseOEApps changes to DevTemplate.sol

storage app package.json storage app Storage.sol

The dev template compiles (verified by navigating into the dev template directory and manually running npm run compile). But attempting to npm run start:dev from the root directory gets a VM revert: 

Using network 'rpc'.

Error: VM Exception while processing transaction: revert
    at Object.InvalidResponse (/Users/jonathanschwartz/Documents/owl/planning-suite/node_modules/truffle/build/webpack:/~/web3/lib/web3/errors.js:38:1)
    at /Users/jonathanschwartz/Documents/owl/planning-suite/node_modules/truffle/build/webpack:/~/web3/lib/web3/requestmanager.js:86:1
    at /Users/jonathanschwartz/Documents/owl/planning-suite/node_modules/truffle/build/webpack:/packages/truffle-provider/wrapper.js:134:1
    at XMLHttpRequest.request.onreadystatechange (/Users/jonathanschwartz/Documents/owl/planning-suite/node_modules/truffle/build/webpack:/~/web3/lib/web3/httpprovider.js:128:1)
    at XMLHttpRequestEventTarget.dispatchEvent (/Users/jonathanschwartz/Documents/owl/planning-suite/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:64:1)
    at XMLHttpRequest._setReadyState (/Users/jonathanschwartz/Documents/owl/planning-suite/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:354:1)
    at XMLHttpRequest._onHttpResponseEnd (/Users/jonathanschwartz/Documents/owl/planning-suite/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:509:1)
    at IncomingMessage.<anonymous> (/Users/jonathanschwartz/Documents/owl/planning-suite/node_modules/truffle/build/webpack:/~/xhr2/lib/xhr2.js:469:1)
    at IncomingMessage.emit (events.js:214:15)
    at endReadableNT (_stream_readable.js:1178:12)
    at processTicksAndRejections (internal/process/task_queues.js:80:21)

Before diving in any further I wanted to ask you a few Q's:

  1. Is this revert from reaching the gas limit? If so, should we just install the storage app manually after running start:dev with the @aragon/cli?
  2. Is continuing down this path wasted effort? (I only spent about an hour messing with it this morning, so haven't sunk much time into it at all yet).

If the revert is coming from a solidity error that I overlooked, I'm happy to keep poking around (or let me know if you see it!). Would be convenient to not have to separately install.

Thanks for any help!

Schwartz10 commented 4 years ago

https://hack.aragon.org/docs/cli-dao-commands#dao-install