search

AutarkLabs / open-enterprise

A suite of apps that includes allocation, dot voting, issue curation, and other planning tools so organizations can collectively budget and design custom reward & bounty systems.
GNU General Public License v3.0
92 stars 54 forks source link

Rewards: Deep linking #1740

Closed PeterMPhillips closed 4 years ago

PeterMPhillips commented 4 years ago

Rewards Deep Linking

javieralaves commented 4 years ago

Is this supposed to be part of an existing epic?

PeterMPhillips commented 4 years ago

@javieralaves I'm unsure. Best ask @ottodevs

ottodevs commented 4 years ago

Is this supposed to be part of an existing epic?

Yes it is @javieralaves it is part of https://github.com/AutarkLabs/product/issues/13

PeterMPhillips commented 4 years ago

I made the requested fixes but I had to change some of the propTypes that you had set. I returned tabs to an array instead of oneOf(TABS) and I changed requestId to a string since that is the type that is received from the path and the contract. I can change it to number but that would mean converting several other variables as well.

PeterMPhillips commented 4 years ago

Ok, I still see some minor changes that you didn't address (like removing the commented code block), but I guess it is fair enough and it will be harmless for now.

The main goal was achieved and the code it is overall clear and succinct

Thanks for the work!

Weird. I for sure deleted that commented block, I must have pressed ctrl-z a bit too many times while working on something else.