Closed PeterMPhillips closed 4 years ago
I retargeted base branch to dev
, because allocations-newbudgetpanel
PR was already merged
See my implementation. Gotta pass className
On Dec 18, 2019 at 1:38 AM, <Peter Phillips (mailto:notifications@github.com)> wrote:
@PeterMPhillips commented on this pull request.
In apps/allocations/app/components/App/PeriodDetails.js (https://github.com/AutarkLabs/open-enterprise/pull/1767#discussion_r359172050):
- <InfoBlock + title="Next period" + large={
${MONTHS[endDate.getMonth()]} ${endDate.getDate()}
} + small={endDate.getFullYear().toString()} + /> + <InfoBlock + title="Time remaining" + large={remainingArray[0]} + small={remainingArray[1]} + /> +
I was unable to get the css prop to work, it would just come out as undefined when values were passed to it. I used the style prop instead
— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub (https://github.com/AutarkLabs/open-enterprise/pull/1767?email_source=notifications&email_token=AABWDLRE6OPAFVIINJPVDP3QZHAPTA5CNFSM4J2K32HKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCPSKZDQ#discussion_r359172050), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AABWDLWCNZEO2T55W2MOZNLQZHAPTANCNFSM4J2K32HA).
Covers this issue: https://github.com/autarklabs/open-enterprise/issues/1576
There are some changes that affect other components. In particular, I moved the
usePeriod
function fromBudgetDetail
to the hooks folder and it's now being used byNewBudget
andPeriodDetails
Currently, only verified tokens are used to calculate the budget. As you can see in this screen
AUTD
doesn't contribute to the 'Budgeted' field or the 'Budget utilized' field.