search

AutarkLabs / open-enterprise

A suite of apps that includes allocation, dot voting, issue curation, and other planning tools so organizations can collectively budget and design custom reward & bounty systems.
GNU General Public License v3.0
92 stars 54 forks source link

Incorrect status field in Application request #1777

Closed rkzel closed 4 years ago

rkzel commented 4 years ago

Each Application (request for work on a given issue) had a status field containing text version of the application status: Unreviewed, Accepted, Rejected. However, because the application was saved on IPFS in its entirety, including initial Unreviewed status, it was ignoring further (post-request-review) status changes.

It was not a problem, because we never relied on the status being correct. We use review.approved as the ultimately (and correct) source of truth.

The choice was between fixing the status field and removing it. The reasons for choosing to remove it instead of fixing are:

  1. There is no analogous field in Work Submission,
  2. It's more complicated to fix it - correct way of fixing it would require not storing it on IPFS == actively removing it from data we need to store on IPFS,
  3. It's not in use anyway. We have another and equally correct way of determining the application status, and it is the same way we use for Work Submissions. Standards FTW.
rkzel commented 4 years ago

Remove unused status field - yes, that's essentially it, although I wanted to convey a little of that drama I've seen in that file ;)