search

AutarkLabs / open-enterprise

A suite of apps that includes allocation, dot voting, issue curation, and other planning tools so organizations can collectively budget and design custom reward & bounty systems.
GNU General Public License v3.0
92 stars 54 forks source link

Allocations/routing: wait, don't redirect #1782

Closed chadoh closed 4 years ago

chadoh commented 4 years ago

Since it can take quite some time from initial load of an app until the time that it may have enough data loaded to show a certain URL, we do not want to change the route if no matching item is found. Instead, we want to ignore the unknown URL.

This sets us up to do that by making the BudgetDetail component ignore routing, instead passing budget in as a prop. This allows all routing logic to be located in the Routes component in App.js.

I also standardized on usePathHelpers, rather than sometimes using raw usePath.

chadoh commented 4 years ago

Ah, great point, @PeterMPhillips! I removed it