Closed rkzel closed 4 years ago
@javieralaves for the "no filtering results" message/card we can use Aragon's named font size instead of what's currently coded: 28px. The choice we have, for the font size name, is either "great" (37px) or "xxlarge" (22px). Screens:
great:
xxlarge:
Or we can stay at 28px?
@rkzel Can we do textStyle("title2") as described on aragonUI? And textStyle("body2") for the description text. By the way, the line-height in the body2 text seems too large compared to the design, is there a quick fix to that?
@rkzel Can we do textStyle("title2") as described on aragonUI? And textStyle("body2") for the description text.
Sure:
OK, @javieralaves ? :)
By the way, the line-height in the body2 text seems too large compared to the design, is there a quick fix to that?
It was affected by height of the "clear" text (which is a button, not simple text). Fixed, as per the screen.
Looks good to me, awesome @rkzel 👍
No screenshots, because nothing changed visibly. One thing that changed is less console noise, and couple of Axe warnings disappeared.