search

AutarkLabs / open-enterprise

A suite of apps that includes allocation, dot voting, issue curation, and other planning tools so organizations can collectively budget and design custom reward & bounty systems.
GNU General Public License v3.0
92 stars 54 forks source link

DV a11y fixes #1856

Closed rkzel closed 4 years ago

rkzel commented 4 years ago

No screenshots, because nothing changed visibly. One thing that changed is less console noise, and couple of Axe warnings disappeared.

rkzel commented 4 years ago

@javieralaves for the "no filtering results" message/card we can use Aragon's named font size instead of what's currently coded: 28px. The choice we have, for the font size name, is either "great" (37px) or "xxlarge" (22px). Screens:

great:

Screenshot from 2020-01-09 15-33-46

xxlarge:

Screenshot from 2020-01-09 15-37-18

Or we can stay at 28px?

javieralaves commented 4 years ago

@rkzel Can we do textStyle("title2") as described on aragonUI? And textStyle("body2") for the description text. By the way, the line-height in the body2 text seems too large compared to the design, is there a quick fix to that?

rkzel commented 4 years ago

@rkzel Can we do textStyle("title2") as described on aragonUI? And textStyle("body2") for the description text.

Sure:

Screenshot from 2020-01-10 17-18-41

OK, @javieralaves ? :)

By the way, the line-height in the body2 text seems too large compared to the design, is there a quick fix to that?

It was affected by height of the "clear" text (which is a button, not simple text). Fixed, as per the screen.

javieralaves commented 4 years ago

Looks good to me, awesome @rkzel 👍