search

AutarkLabs / open-enterprise

A suite of apps that includes allocation, dot voting, issue curation, and other planning tools so organizations can collectively budget and design custom reward & bounty systems.
GNU General Public License v3.0
92 stars 54 forks source link

feat: bounties tab #1901

Closed PeterMPhillips closed 4 years ago

PeterMPhillips commented 4 years ago

This PR adds a Bounties tab to the Projects app: Peek 2020-01-20 12-55

It also supports swiping on mobile: Peek 2020-01-20 12-56

Additionally, this PR refactors some of the code that queries the issues data. All the queries have been moved from Issues and Bounties into an IssuesQueryContext. This reduces the frequency that the user will see the 'Loading...' screen when they navigate to the Issues and Bounties tabs.

chadoh commented 4 years ago

@javieralaves my understanding of this design was that we decided the white background in the columns should only be as tall as the content within that column, which matches how Trello works. I think Peter may have implemented it using an older design, which has the white background extend to the height of the entire page, even when there's no content in the column.

Which approach would you like us to take here?

javieralaves commented 4 years ago

@chadoh Good point, I didn't update the specifications after our discussion to point that out. If it's a quick-fix to update the issue-responsive column height, let's do it. Otherwise, this is a good iteration that we can improve later on.

chadoh commented 4 years ago

@PeterMPhillips @javieralaves I've updated this to be compatible with the latest dev and made a couple other improvements. Screenshots of dark mode:

Screen Shot 2020-01-23 at 22 10 20

Side scrolling now uses pure CSS instead of a JS plugin:

bounties side scroll 2020-01-23 at 22 11 45

This works well at first page load, but currently breaks when you resize your window, which is a weird browser bug. I doubt this is important enough to justify the complexity & bundle bloat for a JS plugin, though?

One thing that's currently broken in this new version: navigating back from an issue detail page brings you back to the ProjectDetail for that issue, rather than the Bounties tab. I'd like to implement goBack functionality in our usePathHelpers hook to address that, which I've done once before and then discarded, so it shouldn't take long. I don't know if it's worth doing as part of this PR or not.