AutarkLabs / open-enterprise

A suite of apps that includes allocation, dot voting, issue curation, and other planning tools so organizations can collectively budget and design custom reward & bounty systems.
GNU General Public License v3.0
92 stars 54 forks source link

Decoupled projects: Contract changes #1912

Closed topocount closed 4 years ago

topocount commented 4 years ago

Addresses #1875 and #1897

This PR adds functions to the projects contract for:

This PR also contains

Note

rkzel commented 4 years ago

Specification suggests that there should be a fuction to edit project as well as add/remove. Editing will involve only replacing ipfs hash saved in_projectData, so all we need is a simple function like this:

    function updateRepo(bytes32 _repoId, string _repoData) external auth(....?)
     {
        require(isRepoAdded(_repoId), ERROR_REPO_MISSING);
        uint rowToUpdate = repos[_repoId].index;
        repoIndex[repoIndexLength] = _repoId;
        repos[rowToUpdate].repoData = _repoData;
        emit Repo....?
    }

Probably a new right and event to emit need to be added as well - what do you think, @topocount ? Alternatively if it's too complicated for current timeline, maybe we leave it for now and not allow editing projects at all?

topocount commented 4 years ago

Changed base branch to merge, to properly see the exact changes going on here

We're working out of the https://github.com/AutarkLabs/open-enterprise/tree/decentralized-project-integration banch, and this branch has already been merged in there. I'll make your requested changes in there and redirect https://github.com/AutarkLabs/open-enterprise/tree/issue-querying to that branch as well.

topocount commented 4 years ago

This branch has been merged into PR #1941. The review above has been addressed there