Closed topocount closed 4 years ago
Specification suggests that there should be a fuction to edit project as well as add/remove. Editing will involve only replacing ipfs hash saved in_projectData
, so all we need is a simple function like this:
function updateRepo(bytes32 _repoId, string _repoData) external auth(....?)
{
require(isRepoAdded(_repoId), ERROR_REPO_MISSING);
uint rowToUpdate = repos[_repoId].index;
repoIndex[repoIndexLength] = _repoId;
repos[rowToUpdate].repoData = _repoData;
emit Repo....?
}
Probably a new right and event to emit need to be added as well - what do you think, @topocount ? Alternatively if it's too complicated for current timeline, maybe we leave it for now and not allow editing projects at all?
Changed base branch to merge, to properly see the exact changes going on here
We're working out of the https://github.com/AutarkLabs/open-enterprise/tree/decentralized-project-integration banch, and this branch has already been merged in there. I'll make your requested changes in there and redirect https://github.com/AutarkLabs/open-enterprise/tree/issue-querying to that branch as well.
This branch has been merged into PR #1941. The review above has been addressed there
Addresses #1875 and #1897
This PR adds functions to the projects contract for:
This PR also contains
isContract
should be sufficientNote