Auterion / px4-jsbsim-bridge

JSBSim bridge for PX4 SITL/HITL simulations
BSD 3-Clause "New" or "Revised" License
24 stars 39 forks source link

Enable user defined and JSBSim Magnetometer XML Input Mapping #26

Closed mvacanti closed 3 years ago

mvacanti commented 3 years ago

Proposal Description

To Test

mvacanti commented 3 years ago

I am done with my work, are you OK with the way I handled the open issue with JSBSim?

Jaeyoung-Lim commented 3 years ago

@mvacanti Yes, but does this mean that it would fail for other jsbsim distributions?

mvacanti commented 3 years ago

@Jaeyoung-Lim on the current JSBSim release it does not fail outright when using the magnetometer system file, for the first several seconds it creates an EKF magnetometer error that prevents arming due to erroneous startup data followed by a step-change. Once that clears it works fine. I have a PR for JSBSim that will be rolled into the next bug-fix release. The default behavior (no magnetometer JSB system) is unaffected by either.

Jaeyoung-Lim commented 3 years ago

@mvacanti Thanks, looks like your fix went into jsbsim! merging!