Auterion / px4-jsbsim-bridge

JSBSim bridge for PX4 SITL/HITL simulations
BSD 3-Clause "New" or "Revised" License
24 stars 39 forks source link

ENABLING HIL MODE IN JSBSIM BRIDGE #27

Open xfahad100 opened 3 years ago

xfahad100 commented 3 years ago

it seems like it is only sitl enabled. I have successfully enabled serial by changing mavlink tcp port to ttyACM0 in the configs file. I want to enable HIL mode and serial communication at the same time. a little help would be appreciated. thanks

Jaeyoung-Lim commented 3 years ago

@xfahad100 I created a draft pull request from the WIP branch I was working on in #28

Please feel free to move it forward

xfahad100 commented 3 years ago

serial connectivity is resolved, but for hitl simulation, connectivity of gcs udp port is also required.

xfahad100 commented 3 years ago

hil mode is achieved. px4 is sending data through mavlink to qgc in hil simulation

xfahad100 commented 3 years ago

I will close this issue in 24 hours, thanks for your time.

Jaeyoung-Lim commented 3 years ago

@xfahad100 Awesome, so the PR just worked out of the box for you?

xfahad100 commented 3 years ago

@Jaeyoung-Lim No , I had to make some changes related to connectivity with Qgroundcontrol.

xfahad100 commented 3 years ago

They were very minor changes . all credit goes to you! @Jaeyoung-Lim

Jaeyoung-Lim commented 3 years ago

@xfahad100 Would you mind making a PR with your changes included?

xfahad100 commented 3 years ago

@Jaeyoung-Lim Yes I will in few days! I just need to comment outunnecessary changes.

Jaeyoung-Lim commented 3 years ago

@xfahad100 Awesome, thanks! I will keep this open until it is fully resolved and merged :smile:

Also, just pushing the unclean version of it would still help since it will save time on debugging the issue with the original PR

xfahad100 commented 3 years ago

35 #36 merge them @Jaeyoung-Lim

Jaeyoung-Lim commented 3 years ago

@xfahad100 Is there a reason those two are separated in two PRs?

xfahad100 commented 3 years ago

@Jaeyoung-Lim uhh no,, I'm a newbie on github and I cant figure out how to compare changes that I've made in 2 files. So there are 2 prs for each file ..... sorry for the mess

Jaeyoung-Lim commented 3 years ago

@xfahad100 I tried your PR, but was not able to get GPS position. Were you able to fly with the changes you made?

xfahad100 commented 3 years ago

ACM0 is workin fine but USB0(telemetry) is giving tx overflow error.

Jaeyoung-Lim commented 3 years ago

ACM0 is workin fine

Can you confirm that you can fly with the vehicle in the simulation? which airframe were you using?

Jaeyoung-Lim commented 3 years ago

@xfahad100 Any updates?

xfahad100 commented 3 years ago

It starts flying by itself in HIL mode and does not respond to px4 data....

Jaeyoung-Lim commented 3 years ago

@xfahad100 Are you saying that it didn't work for you from the start?

xfahad100 commented 3 years ago

@Jaeyoung-Lim is mag sensor plugin not working at the moment? I will share my results once I am able to fly my vehicle.

Jaeyoung-Lim commented 3 years ago

@xfahad100 Now I am a bit confused. You are saying it worked before and not anymore?

xfahad100 commented 3 years ago

@Jaeyoung-Lim bruhh I never said that.. I am now able to get gps location but I am not able to fly ..

Jaeyoung-Lim commented 3 years ago

@xfahad100 Yes exactly. I have asked you multiple times if it was working since October last year, but you never answered. So are you saying it has never worked since october?

xfahad100 commented 3 years ago

I'm working on it n its almost done...

Jaeyoung-Lim commented 3 years ago

@xfahad100 I am assuming that means it never worked for you.

xfahad100 commented 3 years ago

@Jaeyoung-Lim it is working for me right now

xfahad100 commented 3 years ago

At least it takes input from rc and throw it out to jsbsim

xfahad100 commented 2 years ago

Bro I am doing hitl successfully with px4 and jsbsim and also implementing autopilot

xfahad100 commented 2 years ago

But I have excluded qgroundcontrol