Auterion / px4-ros2-interface-lib

Library to interface with PX4 from a companion computer using ROS 2
BSD 3-Clause "New" or "Revised" License
39 stars 13 forks source link

tests: add rad deg conversion unit tests #26

Closed GuillaumeLaine closed 5 months ago

GuillaumeLaine commented 5 months ago

I just learned that the static, inline, and const qualifiers I added are redundant because the functions are header-only templates and we're passing the argument by value. I can remove them if you think they're unnecessary

bkueng commented 5 months ago

I just learned that the static, inline, and const qualifiers I added are redundant because the functions are header-only templates and we're passing the argument by value. I can remove them if you think they're unnecessary

Since you mention it, yes I would (and the reason why I didn't add them in the first place)