search

Auterion / px4-simulation-ignition

28 stars 24 forks source link

added msg for the airspeed plugin #23

Closed addy1997 closed 2 years ago

addy1997 commented 2 years ago

While I agree that we do need an airspeed measurement, this PR only adds the message for the airspeed and not the sensor plugin.

Could you explain how you are using this message?

Yes, I am working on the airspeed plugin and the associated airspeed SDF files and add them shortly. Hence, this msg file could be useful.

Also, the hello world plugin is used to print Hello world whenever ign gazebo is started.

Jaeyoung-Lim commented 2 years ago

@addy1997 Thank you for the contribution, However I would prefer if we can merge complete PRs e.g. a airspeed message without a airspeed plugin is not useful

addy1997 commented 2 years ago

@Jaeyoung-Lim, okay, I will add the plugin files ASAP. Meanwhile, please check this PR #24, It is useful. Apologies for the inconvenience.

Jaeyoung-Lim commented 2 years ago

@addy1997 Please feel free to reopen the PR when the rest of the implementation is available

Thanks!