Verification code improvements

[hex3l]

Follow of this pull request and related issue #1311

@ljacqu

• We should discuss about error handling. If an email cannot be sent (EmailService#sendVerificationMail returns a boolean indicating success) we do not handle that in the verification code service. This blocks a user from being able to do anything until emails can be sent.

• [ ] Add new messages to notify the user about the state of the email (sent or failed)

  @ljacqu

  • I think we could revisit the methods on RecoveryCodeService. From the naming, isVerificationRequired and isCodeRequired kind of sounds like the same to me. I also wonder if we shouldn't move more of the logic into that service instead of calling a handful of methods in VerificationCommand (I would expect to just call verificationService#checkCode or something).

  @Hex3l

  • isVerificationRequired should define if the user is able to access the verification process checks if the emails are enabled, the user has a real email, the user has the permission and the user has not been verified yet.
  • isCodeRequired should define if the user has a code and must use it to verify his identity checks if the user has a code and has not been verified yet.

• [ ] Find a better way to handle these checks

  @ljacqu

  • Could we add /verify also as label? Would be in line with our /register, /login, etc. commands

• [ ] Add /verify as alternative to /verification

[k-jiang]

New suggestion:

1. Add options to allow /changepassword or /changeemail becoming effective immediately right after /verification, so that ppl don't have to do /changepassword first, then /verification, then /changepassword again, eliminating confusions.

[k-jiang]

2. Require password / email confirmation while doing /register [password] [email]. With registration.type: 'PASSWORD' and registration.secondArg: 'EMAIL_MANDATORY' on, ask the player to type their password and email again to confirm it so no mistake were made.