AuthMe / AuthMeReloaded

The best authentication plugin for the Bukkit/Spigot API!
https://www.spigotmc.org/resources/authmereloaded.6269/
GNU General Public License v3.0
618 stars 514 forks source link

Hide commands such as /msg to unauthenticated player #1675

Open Wenferth opened 5 years ago

Wenferth commented 5 years ago

Before reporting an issue make sure you are running the latest build of the plugin and checked for duplicate issues!

What behaviour is observed:

What happened?

What behaviour is expected:

in the configuration hideChat: true the default chat is hidden but the chat /msg /tell /say ... is not hidden

example Image

Steps/models to reproduce:

Player1 connect in the server and /login password Player2 connect in the server and do not /login password just connect Player1 send a message by /msg Player2 url or message Player2 view a msg "Player1-> me url or message"

Plugin list:

Authme 5.5.0 Snapshot Essentials ....

Environment description

Spigot 1.8.9 Mysql

AuthMe build number:

Authme 5.5.0

Error Log:

Pastebin/Hastebin/Gist link of the error log or stacktrace (if any)

`### Configuration: restrictions:

Can not authenticated players chat?

    # Keep in mind that this feature also blocks all commands not
    # listed in the list below.
    allowChat: false
    # Hide the chat log from players who are not authenticated?
    hideChat: true
    # Allowed commands for unauthenticated `
7wOv6ySCjo commented 5 years ago

https://i.gyazo.com/10d4a2d615a88ae673a1a44a81fd181f.png

ljacqu commented 5 years ago

that would only work if you've allowed those commands to be performed by users before they log in...

Wenferth commented 5 years ago

that would only work if you've allowed those commands to be performed by users before they log in...

not .. I'm talking about a login user can send messages to non login users check a pictures

https://i.gyazo.com/10d4a2d615a88ae673a1a44a81fd181f.png

and my pictures in principal post

ljacqu commented 5 years ago

Oh. Why is that a problem?

Wenferth commented 5 years ago

because the hidechat it's true and it's for block a chat no ? And i have a information private in the /msg all people view i have just connect and not login in the orther user account

ljacqu commented 5 years ago

If you send a private message to a user without any prior interaction, I guess it is

Wenferth commented 5 years ago

You just need to fix your time problem and plugins I'm wrong?

ljacqu commented 5 years ago

I'm not sure what you mean, but we can keep this open since I guess it somewhat constitutes a bug. So now this issue stands for fixing it.

Xephi commented 5 years ago

if we "implement" a fix for this issue, it had to be optional (also a settings), since people usually want to talk to unregistered players to help them to perform registration

Wenferth commented 5 years ago

if we "implement" a fix for this issue, it had to be optional (also a settings), since people usually want to talk to unregistered players to help them to perform registration

ok, or add in the config the commands that we want to hide example we can hide /msg /m but leave /tell giving permission /tell the staff

lifehome commented 5 years ago

So to my understanding, that is, @Wenferth would want to block all inbound communications before a player logs in. Is that correct?

If so, I think this would be a feature request, on implementing an option to block chats before login.

7wOv6ySCjo commented 5 years ago

What if CONSOLE send a /tell to the staff player with his password when join to the server? Thats why @Wenferth want to block any chat type for non logged in players. It seems to me right that an optional configuration is added for this order.

Xephi commented 5 years ago

@7wOv6ySCjo it seems you do not understand the problem like us x) I thinks he wants people cannot send to unregistered/unlogged player any /tell command To do that, we have to filtered out the PlayerChat packet received from the server, it can be easily done with protocollib i think, but we do not have actually any way to bypass it for our own messages