search

AuthMe / AuthMeReloaded

The best authentication plugin for the Bukkit/Spigot API!
https://www.spigotmc.org/resources/authmereloaded.6269/
GNU General Public License v3.0
620 stars 515 forks source link

Config option to disable GeoIP database #2720

Closed 3meraldK closed 12 months ago

ljacqu commented 1 year ago

I don't think the constructor is the correct place to check for this, but rather in isDataAvailable(). It's not just called by the constructor but also in lookup methods, so it would be better to properly catch it in isDataAvailable and to avoid conditional logic in the constructor.

3meraldK commented 12 months ago

Requesting @ljacqu to review

ljacqu commented 12 months ago

Two unit tests fail, and I think we don't need the enabled field since all public data methods go through getCountry() -> I will fix this

ljacqu commented 12 months ago

The changes are now on master. Thanks!