search

Authenticator-Extension / Authenticator

Authenticator generates 2-Step Verification codes in your browser.
https://authenticator.cc
MIT License
3.42k stars 798 forks source link

[FIX] OTP type is ignored #1320

Open olfek opened 1 month ago

olfek commented 1 month ago

Alternative proposal to - https://github.com/Authenticator-Extension/Authenticator/pull/1283

olfek commented 1 month ago

Requesting review @Sneezry @mymindstorm

olfek commented 1 month ago

🛎️🛎️🛎️ @Sneezry @mymindstorm

mymindstorm commented 1 month ago

Earliest I might have time to look at this is Sunday.

olfek commented 1 month ago

@mymindstorm How about this Sunday?

olfek commented 1 month ago

@mymindstorm 📟📟📟

mymindstorm commented 1 month ago

@Sneezry could you look at this one?

olfek commented 4 weeks ago

@mymindstorm ...

~Can you run CI again, I've fixed the build error, we should only have prettier warnings left, which I will address once you make the decision on https://github.com/Authenticator-Extension/Authenticator/pull/1310#issuecomment-2432906853 (same problem of diff pollution applies here).~

EDIT see - https://github.com/Authenticator-Extension/Authenticator/pull/1310#issuecomment-2464889071

olfek commented 1 week ago

@mymindstorm Can you run CI again here too?

olfek commented 3 days ago

@mymindstorm 📣📣📣