AuthorizeNet / sample-code-php

This repository contains working code samples which demonstrate php integration with the Authorize.Net API
MIT License
175 stars 197 forks source link

Un-used vars in getTransactionDetails() function #139

Open buttflattery opened 5 years ago

buttflattery commented 5 years ago

What's the point of declaring the refId for the request when it is not being used in the code anywhere? see this line either the code is missing this param which I don't think so as the request works correctly or it is just because of the copy paste.

gnongsie commented 5 years ago

Hi @buttflattery ,

Thanks for reaching out to us.

The refId is a merchant-assigned reference ID for the request. If included in the request, this value is included in the response. This feature might be especially useful for multi-threaded applications.

I do admit that our sample code (which you linked to) does not use this particular parameter. But it doesn't break the functionality of the code. I will add a comment on the same, in any case.

Please check the comment and reply back if you are satisfied with the explanation.

buttflattery commented 5 years ago

hello @gnongsie i know about the usage of refId wasn't asking about that, but my point was that declaring it inside the GetTransactionDetails is more like irrelevant, why would I need the refIdif i want to get the details of an earlier/older transaction. or if you can give me an example of its usage inside that script.