search

AuthorizeNet / sdk-ruby

Ruby SDK for the Authorize.Net API
Other
88 stars 111 forks source link

Fix type for customerProfileId #181

Closed ianneub closed 2 months ago

ianneub commented 5 years ago

customerProfileId should not be a NumericStringsType, it is a simple string.

This will fix the issue in #180 .

tjbarber commented 4 years ago

Is there any reason why this is not being accepted? Seems like a reasonable and easy fix.

hallmatt commented 1 year ago

Hey @gnongsie - can we get this PR merged into master? Seems to be a good fix for #180

gnongsie commented 2 months ago

We are relying on the API specification / XSD as the source of truth, and not the documentation, which may be a bit delayed in updating the details. In any case, the docs are also in agreement that this field should be a numericString. I am closing this PR as I do not see it as valid anymore.

gnongsie commented 2 months ago

Actually, correction. I must apologize here. This change is valid and I will include it in my own pull request.