AuthorizeNet / sdk-ruby

Ruby SDK for the Authorize.Net API
Other
87 stars 111 forks source link

Fixed type for customerProfileId in request. #185

Closed mdchaney closed 3 weeks ago

mdchaney commented 3 years ago

In CreateCustomerProfileFromTransactionRequest the customerProfileId was improperly specified as a NumericStringsType. This commit removes the designation.

Note that in some places customerProfileId is specified as an Integer, which is correct. There should probably be consistency applied.

Closes #180.

gnongsie commented 3 weeks ago

We are relying on the API specification / XSD as the source of truth, and not the documentation, which may be a bit delayed in updating the details. In any case, the docs are also in agreement that this field should be a numericString. I am closing this PR as I do not see it as valid anymore.

gnongsie commented 3 weeks ago

Actually, correction. I must apologize here. This change is valid and I will include it in my own pull request.