search

Autmor / yourTurn

Foundry Module that adds a visual display whenever the turn changes.
6 stars 15 forks source link

[Module Confliction] UI Shifts to Left When Using Carousel Combat Tracker #20

Open 117ksk opened 1 year ago

117ksk commented 1 year ago

When this module is used in conjunction with the new Carousel Combat Tracker (Foundry V11 port of old Carousel module), the UI will shift to the left when the last players on the carousel are up (see clip below) Carousel Combat Tracker.webm

zero127 commented 1 year ago

It may be a conflict with another module, actually. I don't use CCT anymore and I also have this issue - except vertically. This happens when the source art is too large to display for the screen as it animates into place, and only the first time you enter combat on a launch. I'm not sure if some CSS is the fix, but I've been able to reproduce it in the following way:

I've been trying to narrow it down for like 6 hours and found this issue- similar, but not quite the same. I'm wondering if there's some sort of attachment to the GUI it does, that could be done at launch instead of in combat to prepare the canvas to hold larger art? Just a thought. Not sure if this is even helpful but I figured i'd chime in. Happy to help troubleshoot, too if you begin looking into this.

117ksk commented 1 year ago

Glad to hear it's not just me! Personally, I have only been able to reproduce this using CCT. I have enabled only CCT and Your Turn! and been able to reproduce. At this point I am convinced the issue resides in Your Turn! and not any other module.

zero127 commented 1 year ago

I also noticed I was able to stop the issue for the GM hosting client only, by hiding navigation when starting combat. (i also use Monks Improved Navigation) and when it happened, it was while nav was closing on combat start. So yeah, I think the resolution lies in establishing the placement of the container or object (I have no idea how it actually works, just speculating) being in place before anything else modifies the viewport. It's clearly fine (in my case) once combat's been started, and things are placed once.

Its a shame, too this has become one of our favorite addons at the table. But some folks have slower connections and it takes them 3-4 mins to reconnect and I can't guarantee one of them won't have navigation open (without a UI addon to hide it completely or something) when a turn kicks over... :(

On Fri, Jun 23, 2023 at 2:05 PM 117ksk @.***> wrote:

Glad to hear it's not just me! Personally, I have only been able to reproduce this using CCT. I have enabled only CCT and Your Turn! and been able to reproduce. At this point I am convinced the issue resides in Your Turn! and not any other module.

— Reply to this email directly, view it on GitHub https://github.com/Autmor/yourTurn/issues/20#issuecomment-1604881160, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGIXGOGEBX632SVUNY432PTXMXZJ3ANCNFSM6AAAAAAZPLQ4Z4 . You are receiving this because you commented.Message ID: @.***>

--

EndlessFractal commented 1 year ago

Can you please verify if the issue still occurs on my fork? I've done some work on it, ported to the latest version and patched many bugs over on my fork. Please check at your leisure!

https://github.com/EndlessFractal/yourTurn

zero127 commented 1 year ago

I can say mine is improved, but still is pushing a lot of the UI up. it seems like the Left bar is now unaffected but the whole right panel icons, as well as navigation are still affected. Sorry. :( Thanks for looking into it, at least! Let me know if I can help with anything.

EndlessFractal commented 1 year ago

Unfortunately, I was not able to reproduce the issue. I've created a new world, created 4 default player characters, with the default image. Works fine. Adding some landscape and vertical images to the players made no change. I've tried it with CCT and without. If you press F12, does it show any errors?

zero127 commented 1 year ago

So, my issue wasn't with CCT, and testing with your module isolated, its 100% working even with large portraits- can probably close this one, but i'd say probably the person who opened it respond as well before-

As for my issue, i'll probably make a proper issue for compatibility, as isolating down to just your module no longer causes the issue, so w/e you did, you fixed it doing it at the base. Thanks a ton for that! I'll see if i can run down which module is fighting it, if its a premium one maybe we can connect on discord or something. Either way great work on the patch, and thank you. Soon as i figure out what my problem is i'll make a proper ticket since its not related to this anymore!

Here's video (gif, dropbox hosted) of it working alone, and not working with w/e i have conflicting. So i'll do my due diligence here and figure out who's the culprit. may not even be this module. Anyway, thanks again.

Edit: Found it, Seems Monks Combat Details combined with other modules makes Your Turn push up. Doing more testing to see what the other module is, its just tricky to test, because it doesn't occur unless i fully reload. Using Find The Culprit without ending the combat encounter, the item already attaches to the canvas or gui. its only on the first time lol. Anyway, don't worry about this any further. If i figure it out, i'll see if i can find a setting to turn off or something and if not, i'll properly make a compatibility request, not a bug. Thanks again for looking at all this.

Video in folder, labeled NEW example isolated.gif

Edit edit: It is still the attacher, better steps to reproduce:

Hopefully this helps with at least this issue. Would you prefer i move this to a separate issue? Or just give up. We don't need-need the addon to run our game but we all love the hell out of it. I don't wanna give it up if i can help get it squared away. lol

117ksk commented 1 year ago

I can confirm my issue was occurring with CCT enabled specifically with the "No Carousel" setting selected. This was the UI shifting to the left issue.

Some players in my game (using Chrome) reported seeing their entire screen shift upwards about 50% which seems to be a different issue.

In any case, I have not yet tested the new patch to see if the issue or issues are fixed. Will do so soon.

zero127 commented 1 year ago

Updated my original info post, i was able to show an example of it just being the module, very tricky to make it do it, but somehow i do it every time on accident. Steps in the post. Let me know if there's any other help i can provide, and thanks either way!

EndlessFractal commented 1 year ago

Hopefully this helps with at least this issue. Would you prefer i move this to a separate issue? Or just give up. We don't need-need the addon to run our game but we all love the hell out of it. I don't wanna give it up if i can help get it squared away. lol

I've manage to replicate it consistently. On small screens, it seems that whenever the banner is on the screen, if you switch to the chat menu it goes up. I'll try to fix it...

zero127 commented 1 year ago

If you can that'd be amazing, if not don't stress it. I greatly appreciate you looking into it. It's such an awesome addon, and all my players love it. EIther way, just wanted to say thank you!

GMskoom commented 1 year ago

Hopefully this helps with at least this issue. Would you prefer i move this to a separate issue? Or just give up. We don't need-need the addon to run our game but we all love the hell out of it. I don't wanna give it up if i can help get it squared away. lol

I've manage to replicate it consistently. On small screens, it seems that whenever the banner is on the screen, if you switch to the chat menu it goes up. I'll try to fix it...

This is the exact issue I'm experiencing with one caveat, I'm on a 32" curved monitor. This seems to happen after the first actor ends their turn in the first round. I really appreciate your work here! Can't wait to reveal the updated mod to my players!

GMskoom commented 1 year ago

The .json provided in the above link didn't seem to fix the issue. The thread was all in... Spanish? excuse my ignorance

EndlessFractal commented 1 year ago

The .json provided in the above link didn't seem to fix the issue. The thread was all in... Spanish? excuse my ignorance

The text is in Portuguese. I was merely directing that other use to the main topic of the issue he pointed out. I still haven't figured out the issue.

EndlessFractal commented 1 year ago

I've attempted to fix the issue. I've tested it on my end and couldn't reproduce the issue anymore. Please test at your leisure.

zero127 commented 1 year ago

Will do! Back to edit this shortly!

Edit: Sorry; got caught up with a task this afternoon; the displacement of the UI seems to be fixed, so thanks very, very much! not sure if intentional so i screenshotted it, I added CCT in myself as well, and the text seems to be outside of the animated background bar; not sure if that's by design or not. but i don't think it looks bad, either, i just don't remember it being that way before.

image

Heading to bed for now, but tomorrow I'll do some experimenting, see if its a particular addon conflicting/causing it or not. But thank you so much for all the hard work on this.

EndlessFractal commented 1 year ago

I have just released a new update that should provide improved consistency on smaller screens. The banner has been restored to its previous state.

Cheers!

zero127 commented 1 year ago

Confirming, 1080p, CCT module (and way too many others) 10+ combatants and no ui shift. Thank you so much for all the hard work!

EndlessFractal commented 1 year ago

Thanks again for your feedback! If you run into any issue feel free to post the bug on my fork.

Cheers!