Autmor / yourTurn

Foundry Module that adds a visual display whenever the turn changes.
6 stars 15 forks source link

Module doesn't play well with PF2e NPC Mystification #28

Open anaseskyrider opened 2 months ago

anaseskyrider commented 2 months ago

Your Turn! leaks information that is intentionally hidden in a couple ways.

  1. The name in the banner is revealed, regardless of if the name of that token is actually visible to the player. If it's not visible, it should replace the name with something like "Unknown" or "...". Without this being fixed, it requires you to use name mystification (something that renames the token directly) to hide a creature's name.
  2. While a creature's art IS correctly blacked out while its turn is hidden in an encounter, the smaller preview of its art IS NOT blacked out for the "Up Next" section of the banner.

These two things mean that if you have a token in a combat that is hidden from the tracker, both the token's name and its art are leaked by this module.

EndlessFractal commented 1 month ago

Your Turn! leaks information that is intentionally hidden in a couple ways.

1. The name in the banner is revealed, regardless of if the name of that token is actually visible to the player. If it's not visible, it should replace the name with something like "Unknown" or "...". Without this being fixed, it requires you to use name mystification (something that renames the token directly) to hide a creature's name.

2. While a creature's art IS correctly blacked out while its turn is hidden in an encounter, the smaller preview of its art IS NOT blacked out for the "Up Next" section of the banner.

These two things mean that if you have a token in a combat that is hidden from the tracker, both the token's name and its art are leaked by this module.

I'm attempting to fix this on my fork, would you kindly help me with this?

https://github.com/EndlessFractal/yourTurn/issues/6#issuecomment-2184132187

Help me setup a scene with the necessary things, and I'll do my best to fix it for every PF2e player!