AutoFlowResearch / SmartPeak

Fast and Accurate CE-, GC- and LC-MS(/MS) Data Processing
MIT License
41 stars 13 forks source link

Feat/native file picker #505

Closed bertrandboudaud closed 2 years ago

bertrandboudaud commented 2 years ago

There are a lot of cross-platform system dialog libraries. I've chosen one of them because it's just a header file and seems to fit our requirements:

https://github.com/samhocevar/portable-file-dialogs

It can support directory selection, open files for reading, or for saving.

image

image

(not tested on MacOS)

An option menu (Tools > Option) has been added you can still use the ImGui file picker.

image

Note this also fix the issue here (while implementing this I noticed that the title of the FilePicker is the same as other windows which leads in some cases of a mixing UI): https://github.com/AutoFlowResearch/SmartPeak/issues/484

bertrandboudaud commented 2 years ago

Very clean. Thanks for leaving the option for the ImGui picker. Did you want to wait until testing on MacOS before merging?

Well, we can wait a test on MacOS.