AutoFlowResearch / SmartPeak

Fast and Accurate CE-, GC- and LC-MS(/MS) Data Processing

MIT License

40 stars 13 forks source link

LoadMSP #544

Closed dmccloskey closed 1 year ago

dmccloskey commented 2 years ago

Description

Add a new RawDataProcessor called LoadMSP that loads MSP files into a library member of RawDataHandler that is shared across all Injections
Modifed MatchSpectra to call the library member instead of loading separate files from disk
Added LoadMSP to the sequence initiation method so that users can load the library along with the rest of their sequence

dmccloskey commented 2 years ago

@bertrandboudaud In LoadMSP.cpp on Line 61 I have a line commented out dealing with the Observable structure because it would not build. However, it appears in other RawDataHandlers using the same syntax. It would be great to get your thoughts on that.

bertrandboudaud commented 2 years ago

@bertrandboudaud In LoadMSP.cpp on Line 61 I have a line commented out dealing with the Observable structure because it would not build. However, it appears in other RawDataHandlers using the same syntax. It would be great to get your thoughts on that.

make SequenceHandler inherits from LibraryObservable.

https://github.com/AutoFlowResearch/SmartPeak/commit/a65f8e90650d11a5092a4b4aad7729bef147a9e9

Also you want to use it along with the UI, you'll have to add some code in the EventDispatcher so that your event will be forwarded to the UI thread (it's quite easy, just follow how it has been done for the other observers). We can have a short talk if you decide to have UI to respond to this observer

dmccloskey commented 2 years ago

@bertrandboudaud In LoadMSP.cpp on Line 61 I have a line commented out dealing with the Observable structure because it would not build. However, it appears in other RawDataHandlers using the same syntax. It would be great to get your thoughts on that.

make SequenceHandler inherits from LibraryObservable.

a65f8e9

Also you want to use it along with the UI, you'll have to add some code in the EventDispatcher so that your event will be forwarded to the UI thread (it's quite easy, just follow how it has been done for the other observers). We can have a short talk if you decide to have UI to respond to this observer

Let's discuss this more next week. It would be great to add a visualization of the library spectra to the Spectra widget view.

dmccloskey commented 2 years ago

@bertrandboudaud It looks like there is an issue with code signing on Windows. Has this error popped up before?

bertrandboudaud commented 2 years ago

@bertrandboudaud It looks like there is an issue with code signing on Windows. Has this error popped up before?

No I d'ont think I saw this one. I just started one again, let see if it's a temporary issue with CircleCI