AutoFlowResearch / SmartPeak

Fast and Accurate CE-, GC- and LC-MS(/MS) Data Processing

MIT License

43 stars 13 forks source link

Fix for FitFeaturesEMG #558

Closed dmccloskey closed 1 year ago

dmccloskey commented 1 year ago

Fixes

swapped std::cout for LOGD
changed how FitFeaturesEMG updates the ConvexHull to accommodate a bug in OpenMS Feature::getConvexHulls() which returns the bounding box (4 points that outline the feature) and not the actual hull points when more than a single convex hull is detected, which does not allow for plotting.

dmccloskey commented 1 year ago

@bertrandboudaud Do you have any idea what the build errors are?

bertrandboudaud commented 1 year ago

@bertrandboudaud Do you have any idea what the build errors are?

on linux we can see this error: /root/SmartPeak/src/smartpeak/source/core/RawDataProcessors/FitFeaturesEMG.cpp:156:87: required from here /root/SmartPeak/superbuild/Dependencies/Source/plog/include/plog/Record.h:162:23: error: ambiguous overload for 'operator<<' (operand types are 'plog::util::nostringstream' {aka 'std::__cxx11::basic_ostringstream'} and 'const OpenMS::DataValue') 162 | m_message << data; | ~~^~~