search

AutoHotkey / AutoHotkeyDocs

Documentation for AutoHotkey
https://autohotkey.com/
377 stars 759 forks source link

Request to replace Script Showcase's On-Screen Keyboard with its third-time successor #459

Closed KeronCyst closed 3 years ago

KeronCyst commented 3 years ago

To Joe DF: oops, I didn't realize that Script Showcase suggestions should be filed as "issues" here!

I saw that the Script Showcase's On-Screen Keyboard had some busted functionality (some keys weren't working) and was missing many keys for its ANSI layout.

I partnered with /u/anonymous1184 on Reddit to fix those keys and build upon a key-flashing successor with more capabilities.

I would like to request for the Script Showcase's On-Screen Keyboard to be replaced by the On-Screen ANSI Keyboard: https://gist.github.com/KeronCyst/d6e4468273a823794ca2e686e29ba28a

A demo GIF of the new keyboard is in the comments right under that code on that same page.

I think this could help a lot of people! ☺

joedf commented 3 years ago

I mainly suggested this since the script showcase is part the documentation. 👍

KeronCyst commented 3 years ago

Okay, I put it here now if that may make it seem more official: https://github.com/KeronCyst/OSAK

This is my first-ever repo so I have no idea of what I'm doing, lol.

joedf commented 3 years ago

Looks good 😉👍

Lexikos commented 3 years ago

If this was a PR, I would merge it.

KeronCyst commented 3 years ago

Sorry, this would be my first time ever doing a PR so I'm not sure! Is this right; just drop the code in here? https://github.com/Lexikos/AutoHotkey_L-Docs/compare/master...v2

joedf commented 3 years ago

Sorry, this would be my first time ever doing a PR so I'm not sure! Is this right; just drop the code in here? master...v2

I believe just master, unless you've made a v2 version of the script. Just click the link I have here for you to produce a fork/edit directly from GitHub. master (v1): https://github.com/Lexikos/AutoHotkey_L-Docs/edit/master/docs/scripts/KeyboardOnScreen.ahk

In case you want to update the v2 version: https://github.com/Lexikos/AutoHotkey_L-Docs/edit/v2/docs/scripts/KeyboardOnScreen.ahk

You'll likely need to do a second PR if you want to make for v2 also. You can also reference this issue using "#459".

KeronCyst commented 3 years ago

Hmm, didn't even think of that; just v1 for now! Hmm… I think I did it correctly… forked and then PR'd…