Provide user ids in team + time entries

mlahp7 commented 5 months ago

Added two new settings for clickup time entries
- time_entry_start_date: The start date that determines how far back in time the extractor gets time entries.
- time_entry_assignees: used to fetch time entries assigned to specific users
Updated the schema for time entries. It seems with the release of clickup mobile, there are sometimes null entries for certain properties. I've reached out to clickup support to validate whether this is intentional
Made the 'at' field of the time entry stream the replication key, since for this particular endpoint, it serves as the update_at field.

Notes: _The time_entry_start_date might be overkill but currently there isn't a query param we can use for this endpoint that allows us to query for entries that have changed. Something like date_updated_gt from the get tasks endpoint would be great here_

_The new default behavior for time entries will be to get the entries of ALL users in your team. If you want only a subset of assignees you can use the time_entry_assignees conf._

mlahp7 commented 5 months ago

PR looks great, does this solve for #134 ?

Thanks, yes it does for the most part, minus the location names that was mentioned in their issue. I don't mind tacking them on this PR.

I'm a bit new to singer and taps in general, is the best course of action to add a new setting for this as I've done with the other two configs or is there another preferred way to add these types of configurations?

visch commented 5 months ago

PR looks great, does this solve for #134 ?

Thanks, yes it does for the most part, minus the location names that was mentioned in their issue. I don't mind tacking them on this PR.

I'm a bit new to singer and taps in general, is the best course of action to add a new setting for this as I've done with the other two configs or is there another preferred way to add these types of configurations?

If you could update the README portion of Time Entries to include where this PR would bring us to I'd be good with that. For the config's yes you're doing it right, the only thing you could do on top of that is update the configuration readme portion of the docs (if you run poetry run tap-clickup --about --format=md it'll output markdown for you to copy paste!

mlahp7 commented 3 months ago

PR looks great, does this solve for #134 ?

Thanks, yes it does for the most part, minus the location names that was mentioned in their issue. I don't mind tacking them on this PR. I'm a bit new to singer and taps in general, is the best course of action to add a new setting for this as I've done with the other two configs or is there another preferred way to add these types of configurations?

If you could update the README portion of Time Entries to include where this PR would bring us to I'd be good with that. For the config's yes you're doing it right, the only thing you could do on top of that is update the configuration readme portion of the docs (if you run poetry run tap-clickup --about --format=md it'll output markdown for you to copy paste!

Done

mcarriere commented 2 months ago

Is there something else we need to improve to get this merged?

visch commented 2 months ago

Is there something else we need to improve to get this merged?

Took another peek and left a review!

AutoIDM / tap-clickup

Provide user ids in team + time entries #146