search

AutoIDM / tap-clickup

tap-clickup , singer compliant tap for pulling clickup data
MIT License
12 stars 20 forks source link

Change TagsStream and SharedHierarchyStream primary_keys #43

Closed LucasZielke closed 3 years ago

LucasZielke commented 3 years ago

To comply with singer specifications key_properties needs to exist on top level (or be an empty list), of which Tags and Shared does not have ["id"].

To fix I found that changing the Tags primary key to be indexed by ["name"] would populate with all of the tags used.

For shared hierarchy, I set the primary index to be a null list because Its going to cause inconsistency, if being recorded at this time, as theres no ["id"] attributed to itself. Although, to add them its going to need to get_children and recursively add its shared tasks, lists, and folders

visch commented 3 years ago

Great fix I caught this myself as well on #42 , this will close that! Thank you!

visch commented 3 years ago

The test failed due to #14 , I"ll have to fix that at some point but I"m confident with this so I"ll merge it!

visch commented 3 years ago

The test failed due to #14 , I"ll have to fix that at some point but I"m confident with this so I"ll merge it!

Looks like I was wrong! Put in https://github.com/AutoIDM/tap-clickup/issues/44 I'll dive in with my next PR