search

AutoMapper / AutoMapper.Extensions.OData

Creates LINQ expressions from ODataQueryOptions and executes the query.
MIT License
140 stars 38 forks source link

Update LogicBuilder.Expressions.Utils #187

Closed matthewtquinn1 closed 11 months ago

matthewtquinn1 commented 11 months ago

Resolves #186

matthewtquinn1 commented 11 months ago

@BlaiseD OK to merge? 😄

BlaiseD commented 11 months ago

@matthewtquinn1 - we should be all set once you sign the CLA.

matthewtquinn1 commented 11 months ago

@BlaiseD Thank you.

had a look at the CLA - it says the author must sign it; would that be the author of the repo? Or this PR?

BlaiseD commented 11 months ago

@BlaiseD Thank you.

had a look at the CLA - it says the author must sign it; would that be the author of the repo? Or this PR?

Must be the PR. The CLA check only come up on your first contribution.

matthewtquinn1 commented 11 months ago

@BlaiseD Sorry I've never seen this before. Is there a guide for how to sign it?

matthewtquinn1 commented 11 months ago

@microsoft-github-policy-service agree

BlaiseD commented 11 months ago

This might help. Here's another resource.

matthewtquinn1 commented 11 months ago

@BlaiseD That first link no longer works, they say that it is an old and unused method of doing it now ;(

The second link, I see it suggests how to accept it here but I followed that step and it still hasn't passed https://[cla2.dotnetfoundation.org](https://cla2.dotnetfoundation.org/)/

BlaiseD commented 11 months ago

Here's an example from another PR.

matthewtquinn1 commented 11 months ago

@matthewtquinn1 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="Full Staq Ltd"] Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer. @dotnet-policy-service agree (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer. @dotnet-policy-service agree company="Microsoft" Contributor License Agreement

@dotnet-policy-service agree company="Full Staq Ltd"

matthewtquinn1 commented 11 months ago

@dotnet-policy-service agree company="Full Staq Ltd"

matthewtquinn1 commented 11 months ago

@BlaiseD Got it! Ready to merge :)

BlaiseD commented 11 months ago

@jbogard - is it possible part of the CLA workflow is missing for AutoMapper.Extensions.OData? I suspect the prompt/instructions were not clear/visible for @matthewtquinn1 compared with e.g. this PR from the Expression Mapping repo.