Make expansion name testing against the binding name case insensitive.

AutoMapper / AutoMapper.Extensions.OData

Creates LINQ expressions from ODataQueryOptions and executes the query.

MIT License

140 stars 39 forks source link

Make expansion name testing against the binding name case insensitive. #73

Closed hasandogu closed 4 years ago

hasandogu commented 4 years ago

Fix #68

hasandogu commented 4 years ago

Hey @BlaiseD

What would I need to do to get this through? It is the same failure as the other PR #59:

-Missing value for option 'api-key'

BlaiseD commented 4 years ago

Fixed the build error to "not push" on fork.

hasandogu commented 4 years ago

Thanks @BlaiseD. Yes, the tests would fail without the fix. We should also consider enabling the lower camel case for the web tests as they would fail without the fix, here:

https://github.com/hasandogu/AutoMapper.Extensions.OData/blob/a8f6795ba358bec334f0c7b186bd6b6aed47eb1c/WebAPI.OData.EFCore/Startup.cs#L71

and here:

https://github.com/hasandogu/AutoMapper.Extensions.OData/blob/a8f6795ba358bec334f0c7b186bd6b6aed47eb1c/WebAPI.AspNet.OData.EF6/App_Start/WebApiConfig.cs#L33

Want me to send a PR?

BlaiseD commented 4 years ago

No worries. Sample projects reference the packages i.e. you'd need the new package anyway for the tests to pass.

hasandogu commented 4 years ago

Any chance to push a preview release or should we rely on MyGet?

BlaiseD commented 4 years ago

2.0.3-preview.0.

hasandogu commented 4 years ago

Thanks @BlaiseD