search

AutoMapper / AutoMapper.Extensions.OData

Creates LINQ expressions from ODataQueryOptions and executes the query.
MIT License
140 stars 38 forks source link

Breaking change when upgraded to Microsoft.AspNetCore.OData v8.0.0-preview3 #90

Closed DanielGlos closed 3 years ago

DanielGlos commented 3 years ago

This is a follow-up issue to my previous question #89. When I upgrade to package mentioned in title the namespace for ODataQueryOptions class changes from Microsoft.AspNet.OData.Query to Microsoft.AspNetCore.OData.Query but AutoMapper.AspNet.OData.QueryableExtensions explicitly says that ODataQueryOptions must come from Microsoft.AspNet.OData.Query. It would be nice if you could release a preview package with this change.

BlaiseD commented 3 years ago

That was the namespace in version 7. We should wait until v8 is out of preview before updating the libraries which reference it: AutoMapper.AspNetCore.OData.EF6 and AutoMapper.AspNetCore.OData.EFCore.

Is there a new feature you're trying to use?

DanielGlos commented 3 years ago

No, not any special functionality it's just I want to update my project to NET 5 and for that I need to update Microsoft.AspNetCore.OData because of another dependency I have and then this conflict occures.

BlaiseD commented 3 years ago

So you have a dependency using the preview.

If you PR the Microsoft.AspNetCore.OData.v8 branch, we can release the preview separately from that branch. Better to stay away from multiple release branches typically.

BlaiseD commented 3 years ago

Version 2.2.0-preview.1 references Microsoft.AspNetCore.OData v8.0.0-rc.