search

AutoModality / action-xunit-viewer

XUnit / JUnit HTML Test Reports
MIT License
8 stars 11 forks source link

Fixes #6 Fixed check for error fields and failure fields to be more robust #11

Closed terencejeong closed 3 years ago

aroller commented 3 years ago

@terencejeong no problem about the errors. So glad to have you contributing and this pull request looks like the right kind since you have tests.

Since the Actions are not being kicked off by this PR to show the tests pass, will you please run test/all.sh locally and paste the results of your master.

Additionally, please test your changes with your action by replacing the Action reference in your usage to point at your repository, rather than here. This is how you can verify a release candidate will satisfy your needs....basically showing that if I were to merge your code line into mine, release it and tag it, then it would work the same.

Actions makes that super easy. Recommended in a branch in your target project, change:

        uses: AutoModality/action-xunit-viewer@v1

to 

        uses: terencejeong/action-xunit-viewer@master

Provide a screenshot of that working for you. That gives us all the confidence that your changes are working and the next release will be a keeper. Then you'll update your branch to use the new version or continue using v1 and I'll update the v1 tag to match the new release.

Cheers,

Aaron

terencejeong commented 3 years ago

Hey @aroller thanks for the detailed comments! I hope you're having a good day.

So we pointed the changes to my forked repository and everything works accordingly, please see the screenshot below image

And below is the results from running test/all.sh which all seem to pass

`Inspecting 'test/success_fixture.xml'

(standard input) Inspecting 'test/failure_fixture.xml' Error found in test/failure_fixture.xml: Inspecting 'test/singular_testsuite_success_fixture.xml' Skipping: No file or folder found at test/singular_testsuite_success_fixture.xml Inspecting 'test/singular_testsuite_failure_fixture.xml' Test Fixture Nodes ['am_super'] failed to launch Error found in test/singular_testsuite_failure_fixture.xml: Test Fixture Nodes ['am_super'] failed to launch Inspecting 'test/error_fixture.xml' Error found in test/error_fixture.xml: Inspecting 'test/no_error_field_fixture_success.xml' (standard input) Inspecting 'test/no_error_field_fixture_failure.xml' (standard input) Failure found in test/no_error_field_fixture_failure.xml: Inspecting 'test' Error found in test/error_fixture.xml: Inspecting 'test/success' (standard input) Inspecting 'test/failure' Error found in test/failure/failure_fixture.xml: Inspecting 'test/error' Error found in test/error/error_fixture.xml: Inspecting 'missing.xml' Skipping: No file or folder found at missing.xml Inspecting 'test/missing.xml' Skipping: No file or folder found at test/missing.xml Inspecting 'test/no_error_field_fixture.xml' Skipping: No file or folder found at test/no_error_field_fixture.xml Inspecting 'test/no_error_field_fixture_failure.xml' (standard input) Failure found in test/no_error_field_fixture_failure.xml: `
github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.2.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: