Errors attribute is not always present in .xml files #6

AutoModality / action-xunit-viewer

XUnit / JUnit HTML Test Reports

MIT License

8 stars 11 forks source link

Errors attribute is not always present in .xml files #6 #6

Closed terencejeong closed 3 years ago

terencejeong commented 3 years ago

Hey thanks for the Github action.

Sometimes the xunit tests do not have an errors field.

For e.g.

<testsuite name="Testem Tests" tests="311" skipped="0" failures="0" timestamp="Wed Jan 20 2021 23:19:15 GMT+0000 (UTC)" time="17.588">

However, because of the find_fail function this parses it as an error since it cannot grep for this field.

I have a PR ready for this if you have the time to look

aroller commented 3 years ago

@terencejeong thanks for the contribution. Please verify 1.2.1 fixes the issue and I can migrate the v1 tag to 1.2.1 as Github Actions recommends.

terencejeong commented 3 years ago

@aroller hey thank you for responding! Sorry about this but my PR doesn't actually solve the issue of the error field not being present. I've opened up a new PR and added new tests for if the error field is not present. Sorry for not being more thorough in this process, it's my first time contributing to open source :)

PR: https://github.com/AutoModality/action-xunit-viewer/pull/11

github-actions[bot] commented 3 years ago

:tada: This issue has been resolved in version 1.2.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

aroller commented 3 years ago

Relocated v1 tag to 1.2.2 . Thanks again for your contribution.