search

AutoPacker-OSS / autopacker

MIT License
6 stars 1 forks source link

Fix placement of navbar #70

Closed MrPrecise closed 3 years ago

MrPrecise commented 3 years ago

Added padding to move navbar to a more suited location

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

MrPrecise commented 3 years ago

image

I can't get allign-self to work. I tried align:"center" with no sucess. Regardless I thought the navbar was a set size. Meaning if it don't scale I could just hardcode a padding.

ANicholasson commented 3 years ago

image

I can't get allign-self to work. I tried align:"center" with no sucess. Regardless I thought the navbar was a set size. Meaning if it don't scale I could just hardcode a padding.

Inline styling in JSX is a bit different then regular and uses camel case so it would be alignSelf: "center" instead.

The wrapper also need to be of: display: "flex" to use "align self". If this messes up the styling you can merge in with padding👍

MrPrecise commented 3 years ago

image

With using display: "flex" gives me the opposite, I'll merge this with the hard set padding. If it yield problems in the future with this hard set padding, then I will look into another way to do it.