search

AutoResearch / EEG-GAN

Other
19 stars 1 forks source link

AE-GAN Should force activation based on AE #54

Closed chadcwilliams closed 4 months ago

chadcwilliams commented 12 months ago

If the user accidentally uses a different activation for AE-GAN than they did for the AE, we should force change the parameter to what was used in the AE. Or else, we could remove the parameter for AE-GAN and just use the activation from AE (but not for GAN alone).

whyhardt commented 12 months ago

That's a good point in the case of AE-GAN! If the user wants to use TransformerGAN for some reason (which is not tested yet - but we could do that at some point) the activation function should still be there. But as you said, in the case of AE-GAN there's no actual benefit and even quite a conflict potential in keeping the activation function flexible.

whyhardt commented 4 months ago

added functionality; but only relevant for AE-FF-GAN; AE-TTS-GAN does not take custom activation function