AutoResearch / autora-theorist-bms

MIT License
0 stars 0 forks source link

feat: complete/remove sci-kit learn wrapper to bms model predict method #5

Closed TheLemonPig closed 1 year ago

TheLemonPig commented 1 year ago

Currently some of the experimentalists call the predict method of the bms model rather than the bms estimator itself. Because this seems to work for some users but not others AutoResearch/autora#224. Either way, the existence of the method provides a source of confusion, I think it is important to either remove it or provide it with the full sci-kit learn functionality of a predict method - being able to take both pandas and numpy inputs. Both changes would be simple. Reasons for and against it.

For:

Against:

TheLemonPig commented 1 year ago

This was resolved by adding clarity in the documentation