AutoResearch / autora

Automated Research Assistant
https://autoresearch.github.io/autora/
MIT License
41 stars 5 forks source link

feat: added mixture experimentalist contribution #461

Closed blinodelka closed 1 year ago

blinodelka commented 1 year ago

Description

I added a mixture experimentalist package to the dependencies and documentation:) https://pypi.org/project/mixture-experimentalist/

https://github.com/blinodelka/mixture_experimental_strategies

If the issue is on Github, simply link to it using the '#' symbol; otherwise, provide a notion page link):

Type of change

Features (Optional)

The Mixture Experimentalist identifies novel experimental conditions under which a hybrid of different experimental sampling strategies is used. This mixture can include any custom strategies such as falsification, novelty, crucial experimentation, uncertainty, elimination, aesthetic preferences, and arbitrary preferred/dispreferred regions of the space. The selection of conditions is based on a weighted sum of the scores obtained from these strategies.

Questions (Optional)

Remarks (Optional)

Screenshots (Optional)

younesStrittmatter commented 1 year ago

Hi @blinodelka. This is super amazing, and I am very excited about your contribution! Before we proceed, I made a pull request to the original repository to incorporate a few minor changes.

blinodelka commented 1 year ago

@younesStrittmatter Thanks so much! I accepted all your changes and adjusted the index.md file to include description of the package. All of these changes are incorporated in a new version of the package: mixture-experimentalist 1.0.0a2 (do I need to create a new pull request adding this new version of the package as an optional dependency?)

younesStrittmatter commented 1 year ago

Thanks a lot @blinodelka! This looks good to me. You don't need to create a new pull request. All the changes are already in this one.

younesStrittmatter commented 1 year ago

@benwandrew you are right. It is a sampler and should be called like that

younesStrittmatter commented 1 year ago

@blinodelka: I created a pull request in your repo to reflect the name changes and be more consistent with other autora-experimentalist-samplers

blinodelka commented 1 year ago

@younesStrittmatter @benwandrew thanks for your help! Just updated the repository with the suggested name changes (all the changes are reflected in the new version of the package 1.0.0a3: https://pypi.org/project/mixture-experimentalist/)

blinodelka commented 1 year ago

Although I just noticed that I run onto an issue when trying to add a new release to the github repository on the website (I guess it has something to do with the fact that I've been working with PyPI through console?):( Will try to resolve this!

younesStrittmatter commented 1 year ago

@blinodelka The newest release is on Pypi, which is all that matters to us. Should I create a pull request to add the GitHub action for releases to your repository to make it easier in the future? I can also quickly walk you through the release process via GitHub action if you want to.

blinodelka commented 1 year ago

@younesStrittmatter thank you -- I'd really appreciate if you could walk me through the release process on github! I can jump on a call now or later today if you have time.

younesStrittmatter commented 1 year ago

Changed the mkdocs.yml file to include the code references. As soon as the changes in the pyproject.toml file are addressed, this is ready to be merged.

benwandrew commented 1 year ago

can we commit the suggestions and get this merged!?