Closed cgobat closed 1 year ago
Yes this line has been added now in all places where exception occurs. forecast_df_folds = None ThanksAuto Vimal On Sunday, March 26, 2023 at 02:26:52 AM EDT, Caden Gobat @.***> wrote:
This PR should fix #97 (and, by extension, facebook/prophet#2392).
During the instantiation and construction of Prophet-based models in init.py (lines ~535-577), there is currently a forecasts = None initialization that is never used. I suspect this variable was intended to be forecast_df_folds, which is the variable used later for the forecasts, and matches the pattern used in the auto_SARIMAX model instantiation. If forecast_df_folds is not initialized to None, it will cause problems later on if an exception is encountered during the try/except. This change simply renames that forecasts variable to forecast_df_folds to address this.
You can view, comment on, or merge this pull request online at:
https://github.com/AutoViML/Auto_TS/pull/98
Commit Summary
forecasts
variable -> forecast_df_folds
File Changes
(1 file)
Patch Links:
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>
This PR should fix #97 (and, by extension, facebook/prophet#2392).
During the instantiation and construction of Prophet-based models in
__init__.py
(lines ~535-577), there is currently aforecasts = None
initialization that is never used. I suspect this variable was intended to beforecast_df_folds
, which is the variable used later for the forecasts, and matches the pattern used in theauto_SARIMAX
model instantiation. Ifforecast_df_folds
is not initialized toNone
, it will cause problems later on if an exception is encountered during the try/except. This change simply renames thatforecasts
variable toforecast_df_folds
to address this.