AutocoinLab / autopycoin

Apache License 2.0
3 stars 1 forks source link

issue 21 + strategy unit testing #22

Closed GaetanDu closed 2 years ago

pep8speaks commented 2 years ago

Hello @GaetanDu! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 301:80: E501 line too long (88 > 79 characters)

Line 94:80: E501 line too long (86 > 79 characters) Line 229:80: E501 line too long (80 > 79 characters)

Line 36:80: E501 line too long (108 > 79 characters) Line 42:80: E501 line too long (80 > 79 characters) Line 47:80: E501 line too long (88 > 79 characters)

Line 548:80: E501 line too long (83 > 79 characters) Line 563:80: E501 line too long (88 > 79 characters) Line 568:80: E501 line too long (91 > 79 characters)

Comment last updated at 2022-02-07 23:15:16 UTC
codecov[bot] commented 2 years ago

Codecov Report

Merging #22 (0ea773b) into main (a657e3c) will increase coverage by 0.67%. The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
+ Coverage   89.38%   90.05%   +0.67%     
==========================================
  Files          31       32       +1     
  Lines        1997     2031      +34     
  Branches      294      300       +6     
==========================================
+ Hits         1785     1829      +44     
+ Misses        148      145       -3     
+ Partials       64       57       -7     
Impacted Files Coverage Δ
autopycoin/dataset/generator_test.py 88.14% <ø> (ø)
autopycoin/models/nbeats.py 81.20% <93.33%> (+0.62%) :arrow_up:
autopycoin/layers/strategy.py 86.66% <94.44%> (+4.31%) :arrow_up:
autopycoin/_version.py 100.00% <100.00%> (ø)
autopycoin/dataset/generator.py 90.30% <100.00%> (ø)
autopycoin/layers/nbeats_layers.py 95.85% <100.00%> (+2.07%) :arrow_up:
autopycoin/layers/strategy_test.py 100.00% <100.00%> (ø)
autopycoin/models/nbeats_test.py 100.00% <100.00%> (ø)
autopycoin/models/training.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c345cb9...0ea773b. Read the comment docs.