search

Autodesk-AutoCAD / AutoLispExt

Visual Studio Code Extension for AutoCAD® AutoLISP
https://marketplace.visualstudio.com/items?itemName=Autodesk.autolispext
Apache License 2.0
83 stars 29 forks source link

Update autocompletionProvider.ts #156

Open aeo000000 opened 3 years ago

aeo000000 commented 3 years ago
Objective

  1. Show help description in pop menu of suggestions.( the function name 'vla-set-XXX' must change to 'vla-put-XXX' in webHelpAbstraction.json，its bug)

  2. VScode has some issues to check the "word" range, exp: type "vl-str" and type esc or backspace, continue to type "ing" and select 'vl-string->list' from menu,it will be: 'vl-vl-string->list' . Improved this problem, although it has not been completely solved, for example, typing ‘’-’’ still cannot be displayed as a complete word

Abstractions
Tests performed
Screen shot

image

LanDong-adsk commented 3 years ago

Hello @aeo000000 , before we can merge your PR, please sign this file and send to me (lan.dong@autodesk.com). thanks! https://github.com/Autodesk-AutoCAD/AutoLispExt/blob/main/Autodesk_Form_Ind_Contrib_Agmt_for_Open_%20Source.pdf

JD-Howard commented 3 years ago

@aeo000000 Bullet-1 really needs to be fixed in the C#/JSON. Treating the symptom isn't really a solution.

I really should have noticed this, but think the biggest reason I missed it has to do with your Bullet-2. There are all kinds of things I use in lisp (like colons) that yield nothing worth using so I don't even pay attention to intellisense involving any special characters.

Anyway, unless you really want to dig into a complete nightmare, I'll go fix Bullet-1 in the C#/JSON. I actually plan to rewrite that "prototype" producing the JSON to be more sustainable and with better technologies sometime in the coming months.