Autodesk-AutoCAD / AutoLispExt

Visual Studio Code Extension for AutoCAD® AutoLISP
https://marketplace.visualstudio.com/items?itemName=Autodesk.autolispext
Apache License 2.0
83 stars 29 forks source link

Maintenance #170

Closed JD-Howard closed 2 years ago

JD-Howard commented 2 years ago

Objective

This is purely a cleanup and maintenance PR. We've had odd locations for some core objects and some legacy redirection for a while and it was time to get that sorted out.

Abstractions

All refactoring was performed using WebStorm for maximum accuracy and it was put through manual and automated testing after the refactoring. I chose to put our core objects representing lisp syntax objects in the "astObjects" folder because they are fundamentally "Abstract Syntax Tree" representations and that is the common term used by other language parsing frameworks such as Esprima. Here is the sum of what happened:

Other than what was noted in that list, there is no functionality changes in this PR.

Tests performed

All 202 tests are passing. Also checked the code coverage.

Sen-real commented 2 years ago

@JD-Howard thanks a lot for the cleanup! Is it ready for review?

hualin-wu-2000 commented 2 years ago

This refractoring is great!