search

Autodesk-AutoCAD / AutoLispExt

Visual Studio Code Extension for AutoCAD® AutoLISP
https://marketplace.visualstudio.com/items?itemName=Autodesk.autolispext
Apache License 2.0
83 stars 30 forks source link

Moved acet-ui-progress to ambiguousFunctions #229

Closed ambrosl-adsk closed 1 year ago

ambrosl-adsk commented 1 year ago
Objective

Move the documentation for the acet-ui-progress function to the ambiguousFunctions section of the help source file.

Abstractions

acet-ui-progress function was moved to the ambiguousFunctions section and the previous entry was expanded to support the three different signatures.

Tests performed

Test the changes in Visual Studio code. All three signatures could be seen in the tooltip when hovering over the function name in the editor window. Open Online Help was also tested for the function and worked as expected.

Screen shot

image

ambrosl-adsk commented 1 year ago

@JD-Howard I moved the acet-ui-progress function to the ambiguousFunctions section. Can you take a look to make sure it is as expected.

@Sen-real I'm not able to add reviewers to the PR, this might be as expected though.

Sen-real commented 1 year ago

@JD-Howard, it looks good to me. Do you have any comment on this?

JD-Howard commented 1 year ago

The official docs using this note to represent significant behavior change, without a distinct signature, just doesn't make any sense to me... image

If the docs can't/won't change, then this PR is fine.

ambrosl-adsk commented 1 year ago

@JD-Howard The additional signature was added to the documentation for acet-ui-progress. image