search

Autodesk-Forge / learn.forge.designautomation

Learn Forge Tutorial: Modify your models using Design Automation (AutoCAD, Inventor, Revit & 3dsMax). Available in .NET and Nodejs.
http://learnforge.autodesk.io
MIT License
39 stars 40 forks source link

gitignore should ignore uploaded binaries #20

Closed jeanflowerADSK closed 3 years ago

jeanflowerADSK commented 3 years ago

Just a small issue, this one. Maybe a typo to fix in gitignore.

I'm following the nodejs tutorial and seeing binary files get added to a folder on my machine called 'uploads'. The gitignore file names a folder to ignore called 'upload'.

Perhaps either the gitignore file should be changed, or this line in DesignAutomation.js? router.post('/forge/designautomation/workitems', multer({ dest: 'uploads/'

augustogoncalves commented 3 years ago

the .NET version deletes the file after uploading (see here)

the gitignore is a good suggestion, in case the code fails and the local copy is not deleted.

libvarun commented 3 years ago

it's there in gitignore file, just a spelling mistake, 'upload' should become 'uploads'

libvarun commented 3 years ago

https://github.com/Autodesk-Forge/learn.forge.designautomation/pull/23

petrbroz commented 3 years ago

Thanks Varun :+1: