search

Autodesk-Forge / learn.forge.designautomation

Learn Forge Tutorial: Modify your models using Design Automation (AutoCAD, Inventor, Revit & 3dsMax). Available in .NET and Nodejs.
http://learnforge.autodesk.io
MIT License
39 stars 40 forks source link

README in nodejs branch should be branch-aware in the git instructions #21

Closed jeanflowerADSK closed 3 years ago

jeanflowerADSK commented 3 years ago

This suggestion could help people who aren't familiar with the branches that exist in this repo. Following the instructions here https://github.com/Autodesk-Forge/learn.forge.designautomation/tree/nodejs

I run the git clone invocation as suggested. This generates files on my machine for the master branch. I can't complete the next npm install instruction.

I suggest for the README in the nodejs branch, we add something like instructions to type git checkout origin/nodejs git branch nodejs

This helped me follow all the instructions until I started looking for the sample files. They are in the master branch. I don't know if there's a way to simplify this for people to ease the beginner path to success.

libvarun commented 3 years ago

https://github.com/Autodesk-Forge/learn.forge.designautomation/pull/22

petrbroz commented 3 years ago

Thanks for the info. I agree that having an explicit git checkout step mentioned in the README would be even better to make it clear that the code is actually available in a "special" branch.

Personally I think we should move away from this approach (keeping the client side code in master and having specific language implementations branched off of it) entirely. It's starting to get really difficult to rebase the different branches. Let's discuss that after the Forge Training event.